Where am I going wrong in this conditional dequeuing?

[LunaAl]

Hello,

I'm trying to get a function to execute only if the current page is not a Custom Post type, e.g 'movies', OR if it's not an array of pages, e.g: 'about', 'shop', 'contact' and 'sitemap'.

Contact and sitemap are both child pages of the parent About.

I can get the function to work properly on the CPT 'movies, with this:

add_action('genesis_before_loop','cus_tom_single');
function cus_tom_single() {
     if ( get_post_type() != 'movies' ) {
        remove_action( 'wp_head', 'movies_display_redirect' );
        remove_action( 'wp_footer', 'movies_display_inline' );
     }
}

But as soon as I try to add an ! is_page, the function entirely stops working. I've tried:

add_action('genesis_before_loop','cus_tom_single');
function cus_tom_single() {
     if (  ! is_singular( 'movies' ) || ! is_page( array( 'about', 'contact', 'shop', 'sitemap' ) ) ) {
        remove_action( 'wp_head', 'movies_display_redirect' );
        remove_action( 'wp_footer', 'movies_display_inline' );
     }
}

With no success either. Any suggestions would be most welcome.

[Victor Font]

It could be due to the use of is_singular. You are not using is_singular in the code that works. The is_singular tag is equivalent to ‘is_page( 'movies' ) || is_attachment( 'movies' ) || is_single( 'movies' )’. The first half of your if statement will evaluate to true for everything except the movies CPT. The is_page after the logical OR will never evaluate unless the first half of the statement is false.

You may be better off using is_singular for all of the target pages/posts.

$target_posts = array( 'movies', 'about', 'contact', 'shop', 'sitemap');
if (  ! is_singular(  $target_posts ) )

---

Regards,

Victor
https://victorfont.com/
Call us toll free: 844-VIC-FONT (842-3668)
Have you requested your free website audit yet?

[Author]

Posts