Any Way To Clean This Up?

[Porter]

I'm trying to use a shortcode I wrote, while passing in an attribute with the value returned from get_the_title. The issue is, without wrapping the returned string in quotes, I only get the first word of the title, as the blank space breaks things in the later code with the do_shortcode. To make it work, I did this:

$shortcode = '[beverage_title title='."'".get_the_title()."'".']'; //This is so drunk!
echo do_shortcode($shortcode);

As you can see, the concatenated quotes around get_the_title are borderline ridiculous. The returned value is a string, but it isn't a string wrapped in quotes, which is apparently needed. This works as is, but Is there any cleaner way to write the above code? It's driving me crazy haha.

---

Buy me a beer? | Try DigitalOcean VPS Hosting

[Victor Font]

What exactly are your trying to accomplish with the shortcode? You should probably be using the get_the_title() function in the shortcode itself, not passing as a parameter.

You could assign the output from get_the_title() to a variable and pass the variable. No quotes should be necessary.

$title = get_the_title();
$shortcode = '[beverage_title title=$title]'; //This is so drunk!
echo do_shortcode($shortcode);

---

Regards,

Victor
https://victorfont.com/
Call us toll free: 844-VIC-FONT (842-3668)
Have you requested your free website audit yet?

[Porter]

$shortcode = '[beverage_title title=$title]';

That doesn't work because the variable isn't read, it treats $title as nothing more than a string. Even with the correct code:

	$title = get_the_title();
	$shortcode = '[beverage_title title='.$title.']'; //This is so drunk!
	echo do_shortcode($shortcode);

I'm only getting the first word of the title. With my original code, I get the entire title, spaces, words following, etc. I Googled this a bit, and for some reason, the value has to be wrapped in quotes, it's odd.

---

Buy me a beer? | Try DigitalOcean VPS Hosting

[Author]

Posts