- This topic has 22 replies, 6 voices, and was last updated 13 years, 2 months ago by
.
-
Posts
-
Maybe i've gone mad but i can't see how to add an image logo in Genesis 1.9. The option for "dynamic text/image logo" is not in my theme settings anymore, so i can't get the .header-image class to show up in my body.
I know it's past my bedtime and i should maybe look again with fresh eyes in the morning - but any help would be welcome as it's bugging me!
Thus the heavens and the earth were completed in all their vast array. Genesis 2
I checked one of our theme demos (Freelance) and the settings for image logo were still there. Which theme did you find that it disappeared for you? Have you tried deactivating all of your plugins to see if it's a plugin conflict?
Web: https://wpperform.com or Twitter: @wpperform
We do managed WordPress hosting.
If your theme supports a custom header, then this option is obsolete. Genesis 1.9 clears this up to force people to do it correctly.
Normally i choose "image logo" and then set a background for .header-image #title a .... what is the preferred method now?
Thus the heavens and the earth were completed in all their vast array. Genesis 2
The approach involves using a custom header. See Appearance->Header.
What Travis pointed out is that if your theme has custom header support, the settings to select text or logo have been removed. For Freelance (the theme I checked), there's no custom header support, so the option wasn't disabled. To add custom header support, you'd add something like this to your child theme's functions.php:
add_theme_support( 'genesis-custom-header', array( 'width' => 960, 'height' => 115 ) );
The size parameters would vary by theme. Custom headers that match the exact size specified are easiest to implement because there's no cropping. Just put your actual logo on the left side of the header.
This change was poorly documented. You won't find it anywhere in the release announcement for 1.9, but for existing customers with live sites to maintain, it's an important issue.
Web: https://wpperform.com or Twitter: @wpperform
We do managed WordPress hosting.
Bill thanks for the clarification. I have removed the custom header support and all is now good!
Thus the heavens and the earth were completed in all their vast array. Genesis 2
Bill - wanted to add my thanks for your post. That's a huge deal for me and I was going to be confused and frustrated someday in the near future!
Posh John - what version of Genesis were you running before updating to 1.9.*? Was it earlier than the previous release of 1.8.2? (That's when the Header settings were made to hide when theme support for custom-header was present.)
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
Bill,
> This change was poorly documented. You won’t find it anywhere in the release announcement for 1.9, but for existing customers with live sites to maintain, it’s an important issue.
If it's the change I'm thinking of (hence my question above), this change was made in 1.8.2 - looks like it got missed from the official announcement, but it is (now) present on (my) http://genesischangelog.com/1.8.2
The hiding of the Header setting when genesis-custom-header theme support is present has been since G 1.7.0.
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
(re-opened so that Posh John / Bill can reply. Fellow Mods, please leave open)
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
Hi Gary (thanks for reopening so i can answer)
I was previously using 1.8.2, but since i start all my projects with a base child that i created i never noticed. I started this project with the included genesis-sample which had the header support line in, and didn't think to remove it - now that i have done so, all is good.
Thanks 🙂
Thus the heavens and the earth were completed in all their vast array. Genesis 2
Gary - On thinking about this more, unless Travis has an explanation for his comment that "Genesis 1.9 clears this up to force people to do it correctly" (ie, what changed in 1.9), I think you're probably right that this change pre-dated 1.9 but no one noticed. I based my Twitter question on the combination of 2 things: 1) no one complained before 1.9 and 2) Travis's comment.
It's more than likely that no one complained before because the change in previous versions affected such a small group: those with an older theme who made a custom modification to add header support, which is what Posh John did. On all of our installs of older themes that I checked, none had Posh John's mod, so the dynamic text/logo setting was never removed.
Thanks for the great work on your changelog. It's so thorough and accurate that it is the first place to turn when a notice of a Genesis update appears. And being able to get it done with ambulance rides and a sick child is even more impressive. I hope child and family are ok, and life returns to normal quickly. Genesis 2.0 will be on us in a little bit 🙂
Web: https://wpperform.com or Twitter: @wpperform
We do managed WordPress hosting.
My apologies. The comment for Genesis 1.9 was inaccurate as we did fix the Genesis custom header in 1.9, but the fix was related to a deprecated function, not the option. My apologies.
Why is using a custom header "the right way" ? Lately I see quite a few people asking about inserting their logo. Somehow it does not seem intuitive to use a custom header (which is associated with a full size with) to insert a loge which is often only 300px wide.
I have always just disabled the support for custom headers, also since I do not want clients to start playing with it... Will the logo/text method keep working or are there plans to remove it al together? Does anyone know?
Simplicity is not Simple Webtaurus
And_or -- thanks for asking that. I do the same for the same reason. I disable because I really don't want easy back-end access to design elements at all. I also wondered what I was doing the wrong way . . . . If that is the wrong way, why? Or might it be that there isn't just one "right way" for all situations?
I somewhat agree And_or and Cleo3 on wpsmith's use of the word "correct". Still, I am sure that it was just a quick forum post, so there's no benefit to get picky about word choice. I don't think that the old method of making a setting in Genesis->Theme Settings was "wrong"; it's just old, and because it's old it lacks a benefit of the newer method, which is to use a custom header.
A custom header gives your user the ability to manage the logo from the WP dashboard, something the old method doesn't do. Changing the logo requires changing CSS. You don't have to create a full width header if you don't want to. Granted, most site owners don't change their logos frequently, but I have created a # of sites for firms that did do just that. After launching their sites, they used the new site as a prod to tune up other corporate graphics. They felt that with a functioning site in place, it was easier to let a graphic designer design for the needs of the site rather than try to adapt a site to graphic designs.
There's no one right way for all situations because needs and abilities are different. I have clients that have better Photoshop skills than I do; they love the custom header functionality. I have others that are happy setting a logo in CSS and knowing they can't mess that up. Genesis makes it an easy 1 line action, so everyone can be happy being right.
Web: https://wpperform.com or Twitter: @wpperform
We do managed WordPress hosting.
Please let me clarify "correct." If custom header is activated, then the correct method would be to use the Custom Header. If a child theme enables it as a feature of that theme, then the child theme would be customized with the custom header. However, all child themes have the option as was previously noted that they can remove custom header functionality. Then the "correct" method would be to use CSS styling and the Genesis Theme Options.
Some clients, at least some of my clients, want me to set a default header, but they want to be able to change that header for the various seasons. So I will enable the custom header, set the default header and the appropriate size for just the header. Then the client is instructed via the README how to change the header for whenever they want to change the header. I also provide a templated PSD file for them. However, once the site is launched and out of my hands, I can care less what they do.
For a custom header of a custom size, here is the code that I have as a default copy-paste:
https://gist.github.com/4515883
Thanks for the clarification Travis 🙂
I was afraid I was missing some kind of best practices method or was using something which will be deprecated further along the line...And when the site requires it I use the custom-header option too.
Simplicity is not Simple Webtaurus
Well at least now we all know 🙂 I have also preferred not to use custom header and keep everything where clients can't destroy it, but i appreciate that sometimes it may be necessary to do it that way.
Because i've been doing it my way so long (and from my own base child) i didn't even think to look for that line on the new child sample....and i never noticed the change in the framework.
I guess the moral of this story is if you use a new child theme as a base, check it and rip out the bits you don't need before you start doing any other mods 🙂
Thus the heavens and the earth were completed in all their vast array. Genesis 2
- The forum ‘General Discussion’ is closed to new topics and replies.