Community Forums › Forums › Archived Forums › General Discussion › New Plugin: Genesis Featured Page Advanced
Tagged: featured page widget
- This topic has 15 replies, 5 voices, and was last updated 11 years, 1 month ago by
ndiego.
-
AuthorPosts
-
January 23, 2014 at 4:06 pm #86700
ndiego
MemberHello everyone,
I have used Genesis for quite sometime now and made great use of the core Genesis - Featured Page widget. However, sometimes there is simply the need for a custom image and custom content. Therefore, I just released Genesis Featured Page Advanced that does exactly this. If you are interested please head on over to http://wordpress.org/plugins/genesis-featured-page-advanced/. As this is my first released plugin, I would greatly appreciate feedback and/or criticism. New features will be added as needed or as requested.
Thanks!
January 23, 2014 at 8:07 pm #86728AnitaC
KeymasterThat looks nice. I will share this and try it out.
Need help with customization or troubleshooting? Reach out to me.
January 23, 2014 at 8:09 pm #86729AnitaC
KeymasterOh, What's your Twitter ID? Do you have one?
Need help with customization or troubleshooting? Reach out to me.
January 23, 2014 at 8:15 pm #86731ndiego
MemberThanks for taking a look anitac! My Twitter ID is @nickmdiego.
January 23, 2014 at 8:40 pm #86739coralseait
MemberJanuary 24, 2014 at 3:33 am #86775Gary Jones
MemberLooks good. A few small tips:
1. Follow PHP WP code standards (optional braces are not optional).
2. Be consistent in single line comments ( // ).
3. Refactor widget() into smaller methods for better code readability.
4. You have a deactivation function, but it's not wired up to the deactivation hook.
5. Namespace your JavaScript events (e.g. 'click.gfpa').
6. Use 'use strict';, add the missing var to first JS object, follow JS code standards, avoid anonymous functions to better self-document the code.Overall, a very good first plugin - well done!
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
January 24, 2014 at 5:41 am #86781ndiego
MemberHi Gary,
Thank you very much for reviewing my code. I am self taught so your comments are extremely helpful. I already have some other additions in the works so I will add these edits to my to-do list and hopefully push out a updated version later this weekend.
Thanks again,
NickJanuary 24, 2014 at 7:01 am #86790Gary Jones
MemberYou might consider developing it on GitHub too, where others could help contribute to your code with pull requests.
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
January 24, 2014 at 8:07 am #86800ndiego
MemberI do have it on GitHub, but I only started using GitHub recently so I have a lot to learn. But you can check it out here: https://github.com/ndiego/genesis-featured-page-advanced. Again, I really appreciate all of your feedback.
January 28, 2014 at 6:30 am #87473wizz6113
MemberHi, I used your Featured Page Advanced plugin to customise my featured homepage slots in Genesis Streamline Pro theme.
One question, I've tweaked the CSS to remove the theme's huge 'read more' buttons so as to have just a text 'read more' link. But I want to see how I can run the text link directly on (with a few spaces between) the custom excerpt text. A bit like on this site here:
I have opted in your plugin settings to left align my icons. Now though I have ragged left text against the image. So that's an issue to sort too, and I'm not sure how, via your plugin or via some CSS code somewhere. Any ideas on these two points? I
January 28, 2014 at 6:40 am #87475ndiego
MemberHi wizz6113,
Both of these issues should be able to be fixed with CSS. Can you provide me with a link to the site you are working on and I will take a look? The plugin itself doesn't really add any of its own CSS, other than what comes standard with the Genesis Featured Page core widget.
Thanks,
NickJanuary 28, 2014 at 6:46 am #87476wizz6113
MemberNick thanks, yes, I am sure it's CSS somewhere but I prob not seeing the wood for trees. I am working local dev so I've taken a screen grab and put it up on our current site as a hidden page here:
http://www.strategyworks.net/sw-streamline-read-button-featured-widget-issue/
If you've any ideas how I can get the 'read more' text to butt up (leaving a few space gap) to the custom excerpt, like on that dog site link above, that would be great. Thanks!
January 28, 2014 at 7:00 am #87483ndiego
MemberSo it is a bit hard for me to tell you exactly the problem from the screenshot, but here are my thoughts:
The "Read More" link is predominantly controlled by the
more-link
CSS class. Other than that, it is just a link<a>…</a>
. So my thought is thatdisplay
on themore-link
class is set to something likedisplay:block
. Try changing this todisplay:inline
. Hopefully this should bump it up. Also you will want to make sure there are no margin or padding settings on themore-link
class.As for the ragged text, this one it a bit more interesting. Are your images square or round? If they are round, that could explain the issue. If not, this is not something I have seen before, but a nice work around might be to set
padding-left: __px
on theentry-content
class. This is what controls the styling of the text. You will have to play with this, but adding a certain amount of padding should align the text.I hope this helps,
Nick
January 28, 2014 at 7:34 am #87484wizz6113
Memberthanks Nick,
I've left aligned the text around a square image, so that's sorted, I just need to adjust the actual custom excerpt lenght for neatness. However, the padding or whatever around the (defunct) button now 'read more' text eludes me. I can find this in the CSS which might be where I need to adjust padding? As you see, I've put align left on the text already in this part of the code.
Serious thanks for your help!
/* Featured Content
--------------------------------------------- */.featured-content .entry {
margin-bottom: 20px;
margin-bottom: 2rem;
padding: 0 0 24px;
padding: 0 0 2.4rem;
}.featured-content .entry-title {
font-size: 24px;
font-size: 2.4rem;
line-height: 1.2;
}.featured-content .entry-header,
.featured-content .entry-content {
padding: 0;
text-align:left;
}.featured-content .entry:last-child {
margin: 0;
padding: 0;
}.featured-content .entry-meta {
padding-bottom: 0px;
padding-bottom: 0rem;
}.featured-content .entry-author,
.featured-content .entry-time,
.featured-content .entry-comments-link {
display: block;
}January 28, 2014 at 8:22 am #87493wizz6113
MemberNick,
I discovered the 'inline' code in a totally different part of the CSS. On line 1280. All resolved now! Thanks.The problem is that 'featured content' seems to crop up a couple of times in the lengthy CSS so one can't always find the right part to edit. I am a newbie to it all, but thanks to forum members, and past issue threads as well, I am coping.
PS. Nick, forgot to say your plugin resolved a major issue with that featured content customising so thanks for that big time!
January 28, 2014 at 8:51 am #87495ndiego
MemberGreat! I am glad it all worked out. Let me know if I can help in any other way.
- Nick
-
AuthorPosts
- The forum ‘General Discussion’ is closed to new topics and replies.