Community Forums › Forums › Archived Forums › General Discussion › Genesis 2.1.0 Header Bug with OptimizePress
Tagged: Genesis 2.1.0
- This topic has 4 replies, 3 voices, and was last updated 10 years, 8 months ago by
drmac.
-
AuthorPosts
-
June 30, 2014 at 3:32 pm #112203
drmac
MemberHi, guys!
Thank you for always pushing the envelope with your updates. I absolutely LOVE what you guys are doing!
I just updated one of my sites to Genesis 2.1.0 and it's causing a header issue with pages I've created with OptimizePress 2.2.1.1 plugin (which is their latest version). I've verified that it isn't an issue with OptimizePress by deactivating all other plugins except OptimizePress. When I deactivate Genesis and switch to a different theme, the issue goes away completely as well. Also, it strips my SEO settings. My Site Title reads as my URL, etc...
Any ideas on how to fix this?
Thanks,
Patrick
http://www.nextgenerationchiropractor.com/June 30, 2014 at 8:08 pm #112294Brad Dalton
ParticipantJuly 13, 2014 at 11:26 am #114142drmac
MemberSorry, Brad, for the delay. I resorted back to on older version of Genesis for most of my sites since all of my pages created with OptimizePress were showing this glitch.
In the interim, you can see the problem over at http://www.chiroimages.com/
The actual title of the page shouldn't show on the page. You'll see it in the header section of the site stated as... Chiropractic Images — Social Media Images for Chiropractors
Every page that's been created with OptimizePress inside of Genesis now shows this glitch. It isn't an OptimizePress issue because if I change themes to something other than Genesis, the issue goes away.
Thanks for your help!
July 14, 2014 at 4:43 pm #114306Gary Jones
MemberHi Patrick,
I've not seen the OP code, but the evidence I see points to the problem being with OP, and the assumptions it's making with Genesis.
Your site (and another site I was linked to that showed the same problem and had OP installed) both have elements in the header that are not standard for Genesis - it has evidence of HTML5 Boilerplate for the Doctype and
<html>
tag for instance. This suggests that OP is either filtering the genesis_doctype, or have provided a header.php which themes should use, i.e. custom code.Before Genesis 2.1.0, Genesis used to filter a function called wp_title() so that it included the
<title>...</title>
tags. It was wrong that it did that, and it's possible that OP checked to see if a Genesis child theme was present and adjusted it's output accordingly. In pseudocode:if ( genesis child theme is active)
echo the title
else
echo <title>the title</title>This would also explain why changing to a non-Genesis child theme fixes the problem, since the condition fails, and OP adds the title tags.
However, Genesis 2.1.0 fixed this, so that in the Genesis header.php (which is then used by all child themes, unless it already has a custom header.php) the <title> tags were not part of what is returned. If the above pseudocode is still in place in OP, then you can see that although the Genesis child theme is still active, OP is just displaying the title with no tags.
If you look at the page you linked to, then your browser tab will show the page URL. This only tends to happen when the page has no title tag, or an empty title tag. In this case, it's no title tag. If you look at the source, the 11th line shows your page title, not wrapped in tags, where the title tag would usually be.
So while a change in Genesis did likely cause this problem, it was fixing something that was broken, and OP and its custom code has not kept up to date with the changes in Genesis 2.1.
(Again, all speculation as I've not seen the code for OP.)
WordPress Engineer, and key contributor the Genesis Framework | @GaryJ
July 14, 2014 at 7:45 pm #114336drmac
MemberThanks, Gary. Your response makes total sense.
I'll just downgrade the framework and notify OP about the conflict to see if they can fix it.
Thanks again! You can close this discussion.
-
AuthorPosts
- The forum ‘General Discussion’ is closed to new topics and replies.