Feedback: comments.php possible https bug?

[Sybre Waaijer]

Hello 🙂

I'm new to these forums so I'd like to say hi to everyone beforehand! ^^

Now, about the possible bug, I see the following on line 293 in 'lib/structure/comments.php':

if ( ! empty( $url ) && 'http://' !== $url ) {
					$author = sprintf( '<a href="%s" %s>%s</a>', esc_url( $url ), genesis_attr( 'comment-author-link' ), $author );
				}

What I notice is that it doesn't take https into account, now I know that it will default to the line below if it has https, but I'm not quite sure if that's intended.

A possible bugfix would be:

if ( ! empty( $url ) && ('http://' !== $url ||  'https://' !==$url ) ) {
					$author = sprintf( '<a href="%s" %s>%s</a>', esc_url( $url ), genesis_attr( 'comment-author-link' ), $author );
				}

Just wanted to let you know 🙂

Have a great day!

---

Oh, while this is also a showcase forum:
https://hostmijnpagina.nl (front page)
https://hostmijnpagina.nl/nieuws/host-mijn-pagina-heeft-een-nieuw-jasje/ (blog item)
https://hostmijnpagina.nl/dkjhfdfgf/ (404: Oops you blew up the internet) ^^
https://lightspring.hostmijnpagina.nl/2014/12/28/hallo-wereld/ (comment nesting example :D)

Built from the ground up with Gravity Forms and MultiSite user integration 🙂
Also perfectly optimized and useable for mobile without the need of javascript 😀

Almost finished and bbPress integration will come soon. I might release this theme to the public but I'm not making any promises ^^

[Susan]

As you posted this a while ago, I hope you were able to get your issue resolved. If it is resolved, please mark this thread as “resolved”, so it can be closed.

If you are still having issues, report back here, and I will try to escalate.

[Sybre Waaijer]

Hi Susan 🙂

Well, I never had a problem with it since I rewrote the comments structure.

Either way, I dug deeper into the code and I'm not sure if a mistyped URL in 'get_comment_author_url()' string will always return http:// on an SSL enabled website, but it might also be https://.

Of course this check has been enabled to prevent an empty URL output and it's quite unlikely that it will do so, but it might be nice to add https:// as a check too to make the Genesis Framework even more rock-solid 🙂

Thanks and have a great day! 🙂

[Author]

Posts