Correct Include Funtion

[Angelo]

Hello, I have created a function and I would like to know if I am doing it correctly.

1) I have removed the default header from genesis.
2) I have created a file called header.php
3) I put the html code in the file
4) I included the file in the header with the following function

function CustomHeader() {
   include("cabecera.php"); 
};
add_action('genesis_header', 'CustomHeader');

Everything works fine, however, I would like to know if it really is the right way.

https://www.facebook.com/angeloaguilarq

[Gary Jones]

I hope by 1. you mean you've unhooked genesis_do_header, rather than directly edited Genesis files...

In terms of the code snippet, I'd flesh it out as:

remove_action( 'genesis_header', 'genesis_do_header' );
add_action( 'genesis_header', 'angelo_do_header' );
/**
 * Include custom header contents.
 *
 * @since 1.0.0
 */
function angelo_do_header() {
   include __DIR__ . '/cabecera.php'; 
}

There are several differences going on here, including code standards, documentation, best practices and cleaner code.

---

WordPress Engineer, and key contributor the Genesis Framework | @GaryJ

[Angelo]

Yes Gary, I did it Like This:

// Remove site header elements.
remove_action( 'genesis_header', 'genesis_header_markup_open', 5 );
remove_action( 'genesis_header', 'genesis_do_header' );
remove_action( 'genesis_header', 'genesis_header_markup_close', 15 );

function CustomHeader() {
   include("cabecera.php"); 
};
add_action('genesis_header', 'CustomHeader');

I must confess that I'm just an amateur, I'm not a programmer. That's why I ask, because I'd like to do it the right way.
Thank you very much, I will do as you indicate

[Angelo]

Hey Gary, according to what you have indicated, if I wanted to do the same with the footer ...it would be like this?

remove_action( 'genesis_footer', 'genesis_do_footer' );
add_action( 'genesis_footer', 'angelo_do_footer' );
function angelo_do_footer() {
   include __DIR__ . '/myfooter.php'; 
}

Is this correct ?
I just did it, it Woks Fine

[Gary Jones]

If it works, it's correct 🙂

---

WordPress Engineer, and key contributor the Genesis Framework | @GaryJ

[Author]

Posts