Is this PHP code OK with HTML5?

[eluviis]

Hi, this is code I was using for some custom widgets on my old Minimum (pre-HTML5 Minimum Pro). My site is now on Magazine-Pro.

I want these widgets on my new Magazine Pro site but before I go and attempt to make them work, can any of you experts tell me if this code is even correct for use on a HTML5 child theme?

Here's the code:

/** Display custom content box 1 widget after the post content - Needs debugging */
add_action( 'genesis_after_post_content', 'add_custom_content_box_1' );
function add_custom_content_box_1() {
    if ( is_singular( array( 'post', 'quickblog', 'specialty', 'event' ) ) )
    genesis_widget_area( 'custom-content-box-1', array(
        'before' => '<div id="custom-content_box_1 widget-area">',
    ) );
}

/** Display custom content box 2 widget after the post content - Needs debugging */
add_action( 'genesis_after_post_content', 'add_custom_content_box_2' );
function add_custom_content_box_2() {
    if ( is_singular( array( 'post', 'quickblog', 'specialty', 'event' ) ) )
    genesis_widget_area( 'custom-content-box-2', array(
        'before' => '<div id="custom-content-box-2 widget-area">',
    ) );
}

[ᴅᴀᴠɪᴅ]

The hook 'genesis_after_post_content' doesn't exist in the new html5 child themes, it has been replaced with 'genesis_entry_footer'.

You can see the hook changes here New HTML5 Hooks - WPSITES

The other thing is, widget areas are usually written like this..

genesis_widget_area( 'custom-content-box-2', array(
		'before' => '<div class="custom-content-box-2 widget-area">',
		'after'  => '</div>',
) );

The only difference is closing the divs and using classes instead of id's for easier future management of CSS.

---

I love helping creative entrepreneurs build epic things with WP & Genesis.

Follow on Twitter

[eluviis]

Thanks David, that makes sense. I'll keep that in mind. I think that armed with that I can get this to work. Cheers.

[smartal.aundries]

Thanks David this also Help me. 🙂

[Author]

Posts