get_theme_mod vs get_theme_mods

[johnnya23]

It seems that using get_theme_mods and pulling from the array would make sense if you had a lot of mod entries you wanted to incorporate, but values drawn with get_theme_mods do not update in the customizer. though they do work as expected on the live site.

This doesn't make a lot of sense since get_theme_mod uses get_theme_mods

$css = array(
    array(
        'selector' => 'h1,h2,h3,h4,h5,h6',
        'color' => get_theme_mod('jma_gbs_site_title_color')
    ),
    array(
        'selector' => 'body',
        'color' => $mods['jma_gbs_site_font_color'],
        'font-size' => $mods['jma_gbs_site_font_size']
    )
);

the above is css.php the title color changes in customizer, but the body color does not (neither does the size).

this code is called here:

function jma_gbs_header_css()
{
    $mods = get_theme_mods();
    require_once(JMA_GBS_BASE_DIRECTORY . 'jma-css/css.php');
    echo jma_gbs_process_css_array($css);
}
add_action('wp_head', 'jma_gbs_header_css');

obviously both are processd identically.

[Brad Dalton]

Which theme is this for?

---

Tutorials for StudioPress Themes.

[johnnya23]

It's a custom child theme. I don't think the issue is really Genesis related, I have tried the same code in both a theme and a plugin with the same results...

get_theme_mod updates in the customizer, get_theme_mods (then using the value from the resulting array) does not. But get_theme_mods code does implement the change as expected on the live site.

Since I plan to have a reasonably high number of calls to get_theme_mod and each call results in a db hit it seems much more efficient to use get_theme_mods and get all the data from the db at once. Make sense?

[Author]

Posts