ACF fields on archive page are blank if I use pre_get_posts – Why

[mmjaeger]

Hello
I've a custom archive page showing some ACF field values - if I add the following piece of code to the functions.php file, all the ACF fields on the archive page are blank - nothing is shown on the archive page - I'd like to show only posts on that archive page where the status field is set to 'active' - what am I missing.
thank you in advance for you input.

add_action( 'pre_get_posts', 'themeprefix_pre_get_posts' );
function themeprefix_pre_get_posts( $query ) {
	
	if ( is_admin() )
		return $query;
	
	// Show only active job openings
	if ( is_post_type_archive ( 'job' ) ) {
		$query->set( 'meta_key',   'status' );
		$query->set( 'meta_value', 'active' );
	}
	
	return $query;
}

[Victor Font]

pre_get_posts is a little different from other hooks. With pre_get_posts, the $query object is passed to your function by reference. You do not need to return a value. Any changes you make to the object from inside your function are made to the original immediately.

Also meta queries are handled a little differently from the main query object. The main query has an array called meta_query. You have to append your criteria to the meta_auery array.

I haven't tested this, but the approach I would use is:

add_action( 'pre_get_posts', 'themeprefix_pre_get_posts' );
function themeprefix_pre_get_posts( $query ) {
	
	if ( is_admin() ) {
		return;
	}
	
	// Show only active job openings
	if ( is_post_type_archive ( 'job' ) ) {
		$meta_query = $query->get('meta_query');
		$meta_query['status'] = array(
	        	'key' => 'status',
	        	'value' => "yes",
	        	'compare' => '='
	    	);
		$meta_query['active'] = array(
	        	'key' => 'active',
	        	'value' => "yes",
	        	'compare' => '='
	    	);
		$query->set( 'meta_query', $meta_query );
	}
}

You'll have to match up the key and value to the actual values stored in the database, but this should at least point you in the right direction.

---

Regards,

Victor
https://victorfont.com/
Call us toll free: 844-VIC-FONT (842-3668)
Have you requested your free website audit yet?

[Author]

Posts